Add `# frozen_string_literal: true` to all files

e8269096 · Benjamin Neff · 44ebc737 · e8269096 · e8269096 · e8269096
Unverified Commit e8269096 authored Aug 27, 2017 by Benjamin Neff
738 changed files
--- a/.rubocop.yml
+++ b/.rubocop.yml
@@ -170,10 +170,6 @@ Layout/DotPosition:

 ### backward compatibility

-# only with ruby >= 2.3
-Style/FrozenStringLiteralComment:
-  Enabled: false
-
 # only with ruby >= 2.4
 Performance/RegexpMatch:
  Enabled: false
--- a/Gemfile
+++ b/Gemfile
+# frozen_string_literal: true
+
 source "https://rubygems.org"

 gem "rails", "5.1.3"

--- a/Guardfile
+++ b/Guardfile
+# frozen_string_literal: true
+
 guard :rspec, cmd: "bin/spring rspec", all_on_start: false, all_after_pass: false do
  watch(/^spec\/.+_spec\.rb$/)
  watch(/^lib\/(.+)\.rb$/)       {|m| "spec/lib/#{m[1]}_spec.rb" }

--- a/Rakefile
+++ b/Rakefile
+# frozen_string_literal: true
+
 #   Copyright (c) 2010-2011, Diaspora Inc.  This file is
 #   licensed under the Affero General Public License version 3 or later.  See
 #   the COPYRIGHT file.

--- a/app/controllers/admin/admin_controller.rb
+++ b/app/controllers/admin/admin_controller.rb
+# frozen_string_literal: true
+
 module Admin
  class AdminController < ApplicationController
    before_action :authenticate_user!

--- a/app/controllers/admin/pods_controller.rb
+++ b/app/controllers/admin/pods_controller.rb

+# frozen_string_literal: true
+
 module Admin
  class PodsController < AdminController
    respond_to :html, :json, :mobile

--- a/app/controllers/admin/users_controller.rb
+++ b/app/controllers/admin/users_controller.rb
+# frozen_string_literal: true
+
 module Admin
  class UsersController < AdminController


--- a/app/controllers/admins_controller.rb
+++ b/app/controllers/admins_controller.rb
+# frozen_string_literal: true
+
 class AdminsController < Admin::AdminController
  include ApplicationHelper


--- a/app/controllers/api/openid_connect/authorizations_controller.rb
+++ b/app/controllers/api/openid_connect/authorizations_controller.rb
+# frozen_string_literal: true
+
 module Api
  module OpenidConnect
    class AuthorizationsController < ApplicationController

--- a/app/controllers/api/openid_connect/clients_controller.rb
+++ b/app/controllers/api/openid_connect/clients_controller.rb
+# frozen_string_literal: true
+
 module Api
  module OpenidConnect
    class ClientsController < ApplicationController

--- a/app/controllers/api/openid_connect/discovery_controller.rb
+++ b/app/controllers/api/openid_connect/discovery_controller.rb
+# frozen_string_literal: true
+
 # Copyright (c) 2011 nov matake
 #
 # Permission is hereby granted, free of charge, to any person obtaining

--- a/app/controllers/api/openid_connect/id_tokens_controller.rb
+++ b/app/controllers/api/openid_connect/id_tokens_controller.rb
+# frozen_string_literal: true
+
 # Copyright (c) 2011 nov matake
 #
 # Permission is hereby granted, free of charge, to any person obtaining

--- a/app/controllers/api/openid_connect/token_endpoint_controller.rb
+++ b/app/controllers/api/openid_connect/token_endpoint_controller.rb
+# frozen_string_literal: true
+
 module Api
  module OpenidConnect
    class TokenEndpointController < ApplicationController

--- a/app/controllers/api/openid_connect/user_applications_controller.rb
+++ b/app/controllers/api/openid_connect/user_applications_controller.rb
+# frozen_string_literal: true
+
 module Api
  module OpenidConnect
    class UserApplicationsController < ApplicationController

--- a/app/controllers/api/openid_connect/user_info_controller.rb
+++ b/app/controllers/api/openid_connect/user_info_controller.rb
+# frozen_string_literal: true
+
 module Api
  module OpenidConnect
    class UserInfoController < ApplicationController

--- a/app/controllers/api/v0/base_controller.rb
+++ b/app/controllers/api/v0/base_controller.rb
+# frozen_string_literal: true
+
 module Api
  module V0
    class BaseController < ApplicationController

--- a/app/controllers/application_controller.rb
+++ b/app/controllers/application_controller.rb
+# frozen_string_literal: true
+
 #   Copyright (c) 2010-2012, Diaspora Inc.  This file is
 #   licensed under the Affero General Public License version 3 or later.  See
 #   the COPYRIGHT file.

--- a/app/controllers/aspect_memberships_controller.rb
+++ b/app/controllers/aspect_memberships_controller.rb
+# frozen_string_literal: true
+
 #   Copyright (c) 2010-2011, Diaspora Inc.  This file is
 #   licensed under the Affero General Public License version 3 or later.  See
 #   the COPYRIGHT file.

--- a/app/controllers/aspects_controller.rb
+++ b/app/controllers/aspects_controller.rb
+# frozen_string_literal: true
+
 #   Copyright (c) 2010-2011, Diaspora Inc.  This file is
 #   licensed under the Affero General Public License version 3 or later.  See
 #   the COPYRIGHT file.

--- a/app/controllers/blocks_controller.rb
+++ b/app/controllers/blocks_controller.rb
+# frozen_string_literal: true
+
 class BlocksController < ApplicationController
  before_action :authenticate_user!


--- a/app/controllers/comments_controller.rb
+++ b/app/controllers/comments_controller.rb
+# frozen_string_literal: true
+
 #   Copyright (c) 2010-2011, Diaspora Inc.  This file is
 #   licensed under the Affero General Public License version 3 or later.  See
 #   the COPYRIGHT file.

--- a/app/controllers/contacts_controller.rb
+++ b/app/controllers/contacts_controller.rb
+# frozen_string_literal: true
+
 #   Copyright (c) 2010-2011, Diaspora Inc.  This file is
 #   licensed under the Affero General Public License version 3 or later.  See
 #   the COPYRIGHT file.

--- a/app/controllers/conversation_visibilities_controller.rb
+++ b/app/controllers/conversation_visibilities_controller.rb
+# frozen_string_literal: true
+
 #   Copyright (c) 2010-2011, Diaspora Inc.  This file is
 #   licensed under the Affero General Public License version 3 or later.  See
 #   the COPYRIGHT file.

--- a/app/controllers/conversations_controller.rb
+++ b/app/controllers/conversations_controller.rb
+# frozen_string_literal: true
+
 class ConversationsController < ApplicationController
  before_action :authenticate_user!
  respond_to :html, :mobile, :json, :js

--- a/app/controllers/help_controller.rb
+++ b/app/controllers/help_controller.rb
+# frozen_string_literal: true
+
 class HelpController < ApplicationController
 end
--- a/app/controllers/home_controller.rb
+++ b/app/controllers/home_controller.rb
+# frozen_string_literal: true
+
 #   Copyright (c) 2010-2012, Diaspora Inc.  This file is
 #   licensed under the Affero General Public License version 3 or later.  See
 #   the COPYRIGHT file.

--- a/app/controllers/invitation_codes_controller.rb
+++ b/app/controllers/invitation_codes_controller.rb
+# frozen_string_literal: true
+
 class InvitationCodesController < ApplicationController
  before_action :ensure_valid_invite_code


--- a/app/controllers/invitations_controller.rb
+++ b/app/controllers/invitations_controller.rb
+# frozen_string_literal: true
+
 #   Copyright (c) 2010-2011, Diaspora Inc.  This file is
 #   licensed under the Affero General Public License version 3 or later.  See
 #   the COPYRIGHT file.

--- a/app/controllers/likes_controller.rb
+++ b/app/controllers/likes_controller.rb
+# frozen_string_literal: true
+
 #   Copyright (c) 2010-2011, Diaspora Inc.  This file is
 #   licensed under the Affero General Public License version 3 or later.  See
 #   the COPYRIGHT file.

--- a/app/controllers/messages_controller.rb
+++ b/app/controllers/messages_controller.rb
+# frozen_string_literal: true
+
 #   Copyright (c) 2010-2011, Diaspora Inc.  This file is
 #   licensed under the Affero General Public License version 3 or later.  See
 #   the COPYRIGHT file.

--- a/app/controllers/node_info_controller.rb
+++ b/app/controllers/node_info_controller.rb
+# frozen_string_literal: true
+
 class NodeInfoController < ApplicationController
  def jrd
    render json: NodeInfo.jrd(CGI.unescape(node_info_url("123.123").sub("123.123", "%{version}")))

--- a/app/controllers/notifications_controller.rb
+++ b/app/controllers/notifications_controller.rb
+# frozen_string_literal: true
+
 #   Copyright (c) 2010-2011, Diaspora Inc.  This file is
 #   licensed under the Affero General Public License version 3 or later.  See
 #   the COPYRIGHT file.

--- a/app/controllers/participations_controller.rb
+++ b/app/controllers/participations_controller.rb
+# frozen_string_literal: true
+
 class ParticipationsController < ApplicationController
  before_action :authenticate_user!


--- a/app/controllers/people_controller.rb
+++ b/app/controllers/people_controller.rb
+# frozen_string_literal: true
+
 #   Copyright (c) 2010-2011, Diaspora Inc.  This file is
 #   licensed under the Affero General Public License version 3 or later.  See
 #   the COPYRIGHT file.

--- a/app/controllers/photos_controller.rb
+++ b/app/controllers/photos_controller.rb
+# frozen_string_literal: true
+
 #   Copyright (c) 2010-2011, Diaspora Inc.  This file is
 #   licensed under the Affero General Public License version 3 or later.  See
 #   the COPYRIGHT file.

--- a/app/controllers/poll_participations_controller.rb
+++ b/app/controllers/poll_participations_controller.rb
+# frozen_string_literal: true
+
 class PollParticipationsController < ApplicationController
  before_action :authenticate_user!


--- a/app/controllers/posts_controller.rb
+++ b/app/controllers/posts_controller.rb
+# frozen_string_literal: true
+
 #   Copyright (c) 2010-2011, Diaspora Inc.  This file is
 #   licensed under the Affero General Public License version 3 or later.  See
 #   the COPYRIGHT file.

--- a/app/controllers/profiles_controller.rb
+++ b/app/controllers/profiles_controller.rb
+# frozen_string_literal: true
+
 #   Copyright (c) 2010-2011, Diaspora Inc.  This file is
 #   licensed under the Affero General Public License version 3 or later.  See
 #   the COPYRIGHT file.

--- a/app/controllers/registrations_controller.rb
+++ b/app/controllers/registrations_controller.rb
+# frozen_string_literal: true
+
 #   Copyright (c) 2010-2011, Diaspora Inc.  This file is
 #   licensed under the Affero General Public License version 3 or later.  See
 #   the COPYRIGHT file.

--- a/app/controllers/report_controller.rb
+++ b/app/controllers/report_controller.rb
+# frozen_string_literal: true
+
 #   Copyright (c) 2010-2011, Diaspora Inc.  This file is
 #   licensed under the Affero General Public License version 3 or later.  See
 #   the COPYRIGHT file.

--- a/app/controllers/reshares_controller.rb
+++ b/app/controllers/reshares_controller.rb
+# frozen_string_literal: true
+
 class ResharesController < ApplicationController
  before_action :authenticate_user!, except: :index
  respond_to :json

--- a/app/controllers/search_controller.rb
+++ b/app/controllers/search_controller.rb
+# frozen_string_literal: true
+
 class SearchController < ApplicationController
  before_action :authenticate_user!


--- a/app/controllers/services_controller.rb
+++ b/app/controllers/services_controller.rb
+# frozen_string_literal: true
+
 #   Copyright (c) 2010-2011, Diaspora Inc.  This file is
 #   licensed under the Affero General Public License version 3 or later.  See
 #   the COPYRIGHT file.

--- a/app/controllers/sessions_controller.rb
+++ b/app/controllers/sessions_controller.rb
+# frozen_string_literal: true
+
 #   Copyright (c) 2010-2011, Diaspora Inc.  This file is
 #   licensed under the Affero General Public License version 3 or later.  See
 #   the COPYRIGHT file.

--- a/app/controllers/share_visibilities_controller.rb
+++ b/app/controllers/share_visibilities_controller.rb
+# frozen_string_literal: true
+
 #   Copyright (c) 2010-2011, Diaspora Inc.  This file is
 #   licensed under the Affero General Public License version 3 or later.  See
 #   the COPYRIGHT file.

--- a/app/controllers/social_relay_controller.rb
+++ b/app/controllers/social_relay_controller.rb
+# frozen_string_literal: true
+
 class SocialRelayController < ApplicationController
  respond_to :json


--- a/app/controllers/status_messages_controller.rb
+++ b/app/controllers/status_messages_controller.rb
+# frozen_string_literal: true
+
 #   Copyright (c) 2010-2011, Diaspora Inc.  This file is
 #   licensed under the Affero General Public License version 3 or later.  See
 #   the COPYRIGHT file.

--- a/app/controllers/streams_controller.rb
+++ b/app/controllers/streams_controller.rb
+# frozen_string_literal: true
+
 #   Copyright (c) 2010-2011, Diaspora Inc.  This file is
 #   licensed under the Affero General Public License version 3 or later.  See
 #   the COPYRIGHT file.

--- a/app/controllers/tag_followings_controller.rb
+++ b/app/controllers/tag_followings_controller.rb
+# frozen_string_literal: true
+
 #   Copyright (c) 2010-2011, Diaspora Inc.  This file is
 #   licensed under the Affero General Public License version 3 or later.  See
 #   the COPYRIGHT file.

--- a/app/controllers/tags_controller.rb
+++ b/app/controllers/tags_controller.rb
+# frozen_string_literal: true
+
 #   Copyright (c) 2010-2011, Diaspora Inc.  This file is
 #   licensed under the Affero General Public License version 3 or later.  See
 #   the COPYRIGHT file.

--- a/app/controllers/terms_controller.rb
+++ b/app/controllers/terms_controller.rb
+# frozen_string_literal: true
+
 #   Copyright (c) 2010-2011, Diaspora Inc.  This file is
 #   licensed under the Affero General Public License version 3 or later.  See
 #   the COPYRIGHT file.

--- a/app/controllers/users_controller.rb
+++ b/app/controllers/users_controller.rb
+# frozen_string_literal: true
+
 #   Copyright (c) 2010-2011, Diaspora Inc.  This file is
 #   licensed under the Affero General Public License version 3 or later.  See
 #   the COPYRIGHT file.

--- a/app/helpers/activity_streams_helper.rb
+++ b/app/helpers/activity_streams_helper.rb
+# frozen_string_literal: true
+
 module ActivityStreamsHelper
  def add_activitystreams_author(target, person)
    target.author do |author|

--- a/app/helpers/application_helper.rb
+++ b/app/helpers/application_helper.rb
+# frozen_string_literal: true
+
 #   Copyright (c) 2010-2011, Diaspora Inc.  This file is
 #   licensed under the Affero General Public License version 3 or later.  See
 #   the COPYRIGHT file.

--- a/app/helpers/aspect_global_helper.rb
+++ b/app/helpers/aspect_global_helper.rb
+# frozen_string_literal: true
+
 #   Copyright (c) 2010-2011, Diaspora Inc.  This file is
 #   licensed under the Affero General Public License version 3 or later.  See
 #   the COPYRIGHT file.

--- a/app/helpers/contacts_helper.rb
+++ b/app/helpers/contacts_helper.rb
+# frozen_string_literal: true
+
 module ContactsHelper
  def start_a_conversation_link(aspect, contacts_size)
    conv_opts = { class: "conversation_button contacts_button"}

--- a/app/helpers/conversations_helper.rb
+++ b/app/helpers/conversations_helper.rb
+# frozen_string_literal: true
+
 module ConversationsHelper
  def conversation_class(conversation, unread_count, selected_conversation_id)
    conv_class = unread_count > 0 ? "unread " : ""

--- a/app/helpers/error_messages_helper.rb
+++ b/app/helpers/error_messages_helper.rb
+# frozen_string_literal: true
+
 #   Copyright (c) 2010-2011, Diaspora Inc.  This file is
 #   licensed under the Affero General Public License version 3 or later.  See
 #   the COPYRIGHT file.

--- a/app/helpers/getting_started_helper.rb
+++ b/app/helpers/getting_started_helper.rb
+# frozen_string_literal: true
+
 #   Copyright (c) 2010-2011, Diaspora Inc.  This file is
 #   licensed under the Affero General Public License version 3 or later.  See
 #   the COPYRIGHT file.

--- a/app/helpers/gon_helper.rb
+++ b/app/helpers/gon_helper.rb
+# frozen_string_liter