Fix ApplicationHelper#changelog_url with frozen strings

9505eabc · Benjamin Neff · a6b6251b · 9505eabc
Commit 9505eabc authored Aug 27, 2017 by Benjamin Neff
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 2 deletions

app/helpers/application_helper.rb app/helpers/application_helper.rb +3 -2

No files found.
--- a/app/helpers/application_helper.rb
+++ b/app/helpers/application_helper.rb
@@ -17,8 +17,9 @@ module ApplicationHelper
    return AppConfig.settings.changelog_url.get if AppConfig.settings.changelog_url.present?

    url = "https://github.com/diaspora/diaspora/blob/master/Changelog.md"
-    url.sub!('/master/', "/#{AppConfig.git_revision}/") if AppConfig.git_revision.present?
-    url
+    return url if AppConfig.git_revision.blank?
+
+    url.sub("/master/", "/#{AppConfig.git_revision}/")
  end

  def source_url