Commit 749016a7 authored by Steffen van Bergerem's avatar Steffen van Bergerem Committed by Dennis Schubert
Browse files

Fix keyboard shortcuts on profile pages 

closes #6647
parent 960e6517

Changelog.md

+4 −1
Original line number Original line Diff line number Diff line
@@ -4,7 +4,10 @@ 
* Internationalize controller rescue\_from text [#6554](https://github.com/diaspora/diaspora/pull/6554)

* Internationalize controller rescue\_from text [#6554](https://github.com/diaspora/diaspora/pull/6554)





# Bug fixes

# Bug fixes

Fix plural rules handling more than wanted as "one" [#6630](https://github.com/diaspora/diaspora/pull/6630)

* Fix plural rules handling more than wanted as "one" [#6630](https://github.com/diaspora/diaspora/pull/6630)



# Features

* Keyboard shortcuts now do work on profile pages as well [#6647](https://github.com/diaspora/diaspora/pull/6647/files)





# 0.5.6.0

# 0.5.6.0

app/assets/javascripts/app/pages/profile.js

+1 −0
Original line number Original line Diff line number Diff line
@@ -88,6 +88,7 @@ app.pages.Profile = app.views.Base.extend({ 
    if( this.model.get('is_own_profile') ) {

    if( this.model.get('is_own_profile') ) {

      app.publisher = new app.views.Publisher({collection : app.stream.items});

      app.publisher = new app.views.Publisher({collection : app.stream.items});

    }

    }

    app.shortcuts = app.shortcuts || new app.views.StreamShortcuts({el: $(document)});





    return new view({model: app.stream});

    return new view({model: app.stream});

  },

  },

features/desktop/keyboard_navigation.feature

+10 −0
Original line number Original line Diff line number Diff line
@@ -46,3 +46,13 @@ Feature: Keyboard navigation 
    When I press the "J" key somewhere

    When I press the "J" key somewhere

    And I press the "C" key somewhere

    And I press the "C" key somewhere

    Then the first comment field should be open

    Then the first comment field should be open

  

  Scenario: navigate downwards on a profile page

    When I am on "alice@alice.alice"'s page

    And I press the "J" key somewhere

    Then post 1 should be highlighted

    And I should have navigated to the highlighted post



    When I press the "J" key somewhere

    Then post 2 should be highlighted

    And I should have navigated to the highlighted post