Unverified Commit 4cb365a6 authored by Steffen van Bergerem's avatar Steffen van Bergerem Committed by Benjamin Neff
Browse files

Fix missing photos in the single post view 

closes #7545
parent b49b3367

app/assets/javascripts/app/views/content_view.js

+3 −4
Original line number Diff line number Diff line
@@ -17,15 +17,14 @@ app.views.Content = app.views.Base.extend({ 


  largePhoto : function() {

    var photos = this.model.get("photos");

    if(!photos || photos.length === 0) { return }

    if (!photos || photos.length === 0) { return false; }

    return photos[0];

  },



  smallPhotos : function() {

    var photos = this.model.get("photos");

    if(!photos || photos.length < 2) { return }

    photos.splice(0, 1); // remove first photo as it is already shown as largePhoto

    return photos;

    if (!photos || photos.length < 2) { return false; }

    return photos.slice(1); // remove first photo as it is already shown as largePhoto

  },



  expandPost: function(evt) {

spec/javascripts/app/views/content_view_spec.js

+7 −1
Original line number Diff line number Diff line
@@ -4,11 +4,17 @@ describe("app.views.Content", function(){ 
    this.view = new app.views.Content({model : this.post});

  });



  describe("rendering", function(){

  describe("smallPhotos", function() {

    it("should return all but the first photo from the post", function() {

      this.post.set({photos : [1,2]}); // set 2 Photos

      expect(this.view.smallPhotos().length).toEqual(1);

    });



    it("shouldn't change the photos array", function() {

      this.post.set({photos: [1, 2]}); // set 2 Photos

      this.view.smallPhotos();

      expect(this.post.get("photos").length).toEqual(2);

    });

  });



  describe("presenter", function(){