Commit 1773e3e3 authored by Ralin Chimev's avatar Ralin Chimev Committed by Dennis Schubert

Do not change notification timestamp when making it read or unread.

Marking a notification as unread resets the timeago stamp causing
the times to look wrong. It can be reproduced by marking an old
notification as unread. Using the update_column instead of
update_attribute will not touch the updated_at attribute, and
thus will not affect the updated time ago in the view.

Fixes #6798.

closes #6821
parent 4cd2f1d9
......@@ -5,6 +5,7 @@
## Bug fixes
* Fix back to top button not appearing on Webkit browsers [#6782](
* Don't reset the notification timestamp when marking them as read [#6821](
## Features
......@@ -41,7 +41,7 @@ class Notification < ActiveRecord::Base
def set_read_state( read_state )
self.update_attributes( :unread => !read_state )
update_column(:unread, !read_state)
def mail_job
......@@ -31,6 +31,19 @@ describe NotificationsController, :type => :controller do
get :update, "id" =>, :set_unread => "true", :format => :json
it "marks a notification as unread without timestamping" do
note = do
FactoryGirl.create(:notification, recipient: alice, unread: false)
get :update, "id" =>, :set_unread => "true", :format => :json
expect(response).to be_success
updated_note = Notification.find(
expect(updated_note.unread).to eq(true)
expect(updated_note.updated_at.iso8601).to eq(note.updated_at.iso8601)
it 'only lets you read your own notifications' do
user2 = bob
......@@ -41,15 +41,17 @@ describe Notification, :type => :model do
describe 'set_read_state method' do
it "should set an unread notification to read" do
@note.unread = true
@note.set_read_state( true )
expect(@note.unread).to eq(false)
it "should set an read notification to unread" do
@note.unread = false
@note.set_read_state( false )
expect(@note.unread).to eq(true)
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment